Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add membership check to procedures #283

Merged
merged 7 commits into from
Apr 30, 2024
Merged

feat: add membership check to procedures #283

merged 7 commits into from
Apr 30, 2024

Conversation

G3root
Copy link
Collaborator

@G3root G3root commented Apr 29, 2024

JWTs can remain stale until they expire. Therefore, when a membership is revoked from a company, although JWTs cannot be revoked individually, they can become stale and potentially grant unrestricted access to the revoked membership. This PR aims to address this issue by implementing a membership check in all authentication required procedures.

@G3root G3root requested a review from dahal April 29, 2024 12:03
Copy link

Thank you for following the naming conventions for pull request titles! 🙏

Copy link
Contributor

@dahal dahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really good, great job @G3root

@dahal dahal merged commit c65d0d2 into main Apr 30, 2024
3 checks passed
@dahal dahal deleted the permission-check branch April 30, 2024 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants