Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes via captainhook binary removes "config" entry from captainhook.json #59

Closed
boesing opened this issue Oct 29, 2019 · 1 comment
Closed

Changes via captainhook binary removes "config" entry from captainhook.json #59

boesing opened this issue Oct 29, 2019 · 1 comment
Assignees
@sebastianfeldmann
Labels
bug

Comments

@boesing
Copy link
Contributor

boesing commented Oct 29, 2019

Hey there,

using vendor/bin/captainhook to either enable, disable or add an action, the \CaptainHook\App\Config\Util::writeToDisk will only write the contents of \CaptainHook\App\Config::getJsonData.

This method only provides the configuration for known (valid) hooks but will drop the config section.
@sebastianfeldmann sebastianfeldmann self-assigned this Oct 29, 2019
sebastianfeldmann added a commit that referenced this issue Oct 29, 2019
@sebastianfeldmann
Add 'config' values to json data
23e5b59 
When extending existing configuration files the 'config' settings got
lost. Now 'getJsonData' returns the 'config' settings as well.

Fixes issue #59
@sebastianfeldmann
Copy link
Collaborator

Thanks @boesing for reporting the issue ;)

I just released version 4.5.3 with a fix for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebastianfeldmann sebastianfeldmann

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@boesing @sebastianfeldmann