Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow interpreter to run without a async/await #814

Closed
captbaritone opened this issue Jul 18, 2019 · 1 comment
Closed

Allow interpreter to run without a async/await #814

captbaritone opened this issue Jul 18, 2019 · 1 comment

Comments

@captbaritone
Copy link
Owner

captbaritone commented Jul 18, 2019 •
edited
Loading

In dev/debugger we need to be able to pause execution, but in prod we don’t want to pay the overhead.

Also, it has complicated all kinds of things by requiring that lots of of other functions become async.

This is fine for now, but it would be nice to come back and clean this up.

Search the code base for #814 to find places where we are awaiting just because of debugging.
captbaritone added a commit that referenced this issue Jul 20, 2019
@captbaritone
Add comments in places where we await because of #814
386d46b
captbaritone added a commit that referenced this issue Nov 30, 2019
@captbaritone
Add comments in places where we await because of #814
2cfec69
@captbaritone
Copy link
Owner Author

Closing since we are not actively working on modern skins any more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@captbaritone