Add runtime version and remove version check hacks #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| function jumpToOffset(offset) { | ||
| const nextCommandIndex = offsetToCommand[offset]; | ||
| return nextCommandIndex - 1; | ||
| } |
There was a problem hiding this comment.
Nice! Eventually I would like to move this into the parser, but having it in one place here in the VM is a huge first step to being able to rip it out.
There was a problem hiding this comment.
oh hadn't even thought about how we could just do that in the parser once and be done, sounds good!
There was a problem hiding this comment.
It's going to be a little annoying, since we will need to do it after all the command parsing is done. That means we will need to do a second pass which knows which opcodes have arguments which are command offsets.
|
That was way easier than I expected. Nice work! |
captbaritone
pushed a commit
that referenced
this pull request
Nov 30, 2019
* add runtime version and remove version check hacks * move jump logic into a shared function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.