Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix script group finding #877

Merged
merged 1 commit into from
Aug 21, 2019
Merged

Fix script group finding #877

merged 1 commit into from
Aug 21, 2019

Conversation

jberg
Copy link
Collaborator

@jberg jberg commented Aug 20, 2019

So this would have been caught by tests, because I found it when checking that my tests worked hah.

findParentNodeOfType is checking against the underlying XML node name, not the object classname, so we still need to use WinampAbstractionLayer.

@captbaritone captbaritone merged commit 0fc4aac into captbaritone:master Aug 21, 2019
captbaritone pushed a commit that referenced this pull request Nov 30, 2019
@jberg @captbaritone
Fix script group finding (#877)
63a2e99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@captbaritone captbaritone Awaiting requested review from captbaritone

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jberg @captbaritone