Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile browser compatible #92

Closed
warmhug opened this issue Jun 14, 2016 · 7 comments · Fixed by #115
Closed

Mobile browser compatible #92

warmhug opened this issue Jun 14, 2016 · 7 comments · Fixed by #115

Comments

@warmhug
Copy link

warmhug commented Jun 14, 2016

On mobile browser, like ios or android, it fire onscroll event when end scroll, this is not good experience.
So, maybe use ontouchmove event instead of onscroll event will be better.

@pvande
Copy link
Contributor

pvande commented Jun 21, 2016

What version of react-sticky are you using?

We are subscribing to the various touch events in at least the last few releases.

@warmhug
Copy link
Author

warmhug commented Jun 22, 2016

I see that, but it seems not very good, whether test performance on mobile?

@pvande
Copy link
Contributor

pvande commented Jun 22, 2016

I definitely agree that it doesn't function correctly on mobile platforms. We're still looking for solutions that will help us close the gap and make mobile browsers behave similarly – the touch events are not that solution, unfortunately.

dbarbalato added a commit that referenced this issue Aug 29, 2016
Fix <Sticky> disappearing on mobile devices (closes #92)
@mengel9
Copy link

mengel9 commented Aug 29, 2016

When will this package version be published?

@dbarbalato
Copy link
Member

I'm planning to do it in my free time tonight.

Dave Barbalato
Owner, Captivation Software, LLC
dave.barbalato@captivationsoftware.commailto:dave.barbalato@captivationsoftware.com
410-928-4157 ext. 101tel:4109284157,,101


From: mengel9 notifications@github.com
Sent: Monday, August 29, 2016 6:20:05 PM
To: captivationsoftware/react-sticky
Cc: Dave Barbalato; State change
Subject: Re: [captivationsoftware/react-sticky] Mobile browser compatible (#92)

When will this package version be published?

You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHubhttps://github.com//issues/92#issuecomment-243275449, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABcbescikobNiXylZ9kr4BcTTM791Uxpks5qk1sUgaJpZM4I1HQX.

@dbarbalato
Copy link
Member

Done - enjoy!

@mengel9
Copy link

mengel9 commented Aug 30, 2016

Great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants