assign_based_on assignments to recipe inputs not reflected in summary

[o-smirnov]

The assignments work correctly, but the summary of recipe inputs that is being printed up front prints the default values without the assignments being applied. This is a cosmetic issue, but can be confusing.

[o-smirnov]

Spotted by @JSKenyon.

Not so quick to fix. It's an unholy interaction between defaults and assign_based_on. The latter changes the default value of a recipe input (as opposed to the input itself), reason being that it still gives the user the opportunity to override assign_based_on with an explicit command-line setting. But assign_based_on is not finally applied until the run() stage. At the validation stage (where the summary is printed), it hasn't quite taken hold yet.

[o-smirnov]

Problem arises here, non-assigned defaults sneak in:

stimela/stimela/kitchen/step.py

Line 256 in 49124e8

for name, value in self.defaults.items():

But commenting it out breaks some substitutions. Need to rethink this a little -- not going to worry for R2.0.

[o-smirnov]

Yep, the deeper issue is that parameters are prevalidated, then revalidated again here, which causes {}-substitution to happen twice. The breakage case is with publish_plots_title parameter of the PARROT recipe, which uses "{{" escapes. The code referenced in the previous comment inadvertently fixes this bug, but only in the case where the "{{" containing strings come from a default. I can probably devise another way to break it.

The validation logic needs to be cleaned up a little to absolutely avoid double substitution. Deferring this until post-2.0.

[o-smirnov]

Note also related to this -- stimela run image-parrot.yml obs=L4 -s flag-reset initial-flag-version='xxx'

2024-03-27 12:25:28 STIMELA.ratt-parrot.flag-reset ERROR: step 'flag-reset': invalid inputs: 'versionname'