Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some styling on the deletion feature #348

Merged
merged 2 commits into from
Jul 20, 2023
Merged

fix some styling on the deletion feature #348

merged 2 commits into from
Jul 20, 2023

Conversation

zenovore
Copy link
Collaborator

@zenovore zenovore commented Jun 30, 2023 •
edited
Loading

This PR is a follow up regarding some issue from the #329 :

  1. Different table alignment from turing and merlin
  2. Hide Terminate/Delete Button when ensembling job is on terminating state

@deadlycoconuts deadlycoconuts self-requested a review July 17, 2023 05:55
deadlycoconuts
deadlycoconuts approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@deadlycoconuts deadlycoconuts left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for these fixes! Really appreciate them! 🚀 I'll let you do the honours to merge it ahahaha

@deadlycoconuts deadlycoconuts mentioned this pull request Jul 18, 2023
Merged
@deadlycoconuts
Copy link
Contributor

deadlycoconuts commented Jul 20, 2023 •
edited
Loading

Haha just a heads up @zenovore, I'll be merging this first :) We've decided to gray out the delete/terminate button if a job is in the terminating state instead of hiding it, but I'll add this fix to my current PR. Thanks a lot for this PR nonetheless!

@deadlycoconuts deadlycoconuts merged commit 3347f34 into caraml-dev:main Jul 20, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deadlycoconuts deadlycoconuts deadlycoconuts approved these changes

Assignees

@zenovore zenovore

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zenovore @deadlycoconuts