More fixes

caraml-dev · Mar 2, 2023 · 468dad8 · 468dad8
1 parent e04b26a
commit 468dad8
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 7 deletions.
diff --git a/management-service/controller/configuration_controller_test.go b/management-service/controller/configuration_controller_test.go
@@ -22,11 +22,15 @@ func (s *ConfigurationControllerTestSuite) SetupSuite() {
 
 	pubSubConfigProject := "dev"
 	pubSubConfigTopicName := "xp-update"
+	messageQueueKind := schema.MessageQueueKindPubsub
 
 	treatmentServicePluginConfiguration := schema.TreatmentServiceConfig{
-		PubSub: &schema.PubSub{
-			Project:   &pubSubConfigProject,
-			TopicName: &pubSubConfigTopicName,
+		MessageQueueConfig: &schema.MessageQueueConfig{
+			Kind: &messageQueueKind,
+			PubSub: &schema.PubSub{
+				Project:   &pubSubConfigProject,
+				TopicName: &pubSubConfigTopicName,
+			},
 		},
 		SegmenterConfig: &schema.SegmenterConfig{
 			"s2_ids": map[string]interface{}{
@@ -65,9 +69,12 @@ func (s *ConfigurationControllerTestSuite) TestGetTreatmentServicePluginConfig()
 	body, err := io.ReadAll(resp.Body)
 	s.Suite.Require().NoError(err)
 	s.Suite.Assert().JSONEq(`{"data":{
-		"pub_sub":{
-			"project":"dev",
-			"topic_name":"xp-update"
+		"message_queue_config": {
+			"kind":"pubsub",
+			"pub_sub":{
+				"project":"dev",
+				"topic_name":"xp-update"
+			}
 		},
 		"segmenter_config":{
 			"s2_ids":{

diff --git a/plugins/turing/runner/experiment_runner.go b/plugins/turing/runner/experiment_runner.go
@@ -257,7 +257,6 @@ func (er *experimentRunner) startBackgroundServices(
 			}
 		}()
 	}
-	return
 }
 
 func (er *experimentRunner) getRequestParams(