Code migration from internal repository #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonlnj
reviewed
May 23, 2022
management-service/database/db-migrations/000001_schema_creation.down.sql
Show resolved
Hide resolved
leonlnj
reviewed
May 23, 2022
leonlnj
reviewed
May 23, 2022
leonlnj
reviewed
May 23, 2022
|
Left some questions for my understanding, overall looks great after the series of refactoring to make things more generic |
krithika369
approved these changes
May 23, 2022
management-service/database/db-migrations/000001_schema_creation.down.sql
Show resolved
Hide resolved
| @@ -0,0 +1,69 @@ | |||
| # XP UI | |||
There was a problem hiding this comment.
We eventually need to add detailed dev README for the management and treatment service APIs, similar to this.
krithika369
reviewed
May 24, 2022
management-service/database/db-migrations/000001_schema_creation.down.sql
Outdated
Show resolved
Hide resolved
krithika369
reviewed
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
As we have achieved a milestone with features supported by XP, we look to open-source our codebase, to contribute back to the community. This PR is the first step in doing so, with the following being migrated over from our internal repository.
The following will be introduced in a separate PR: