-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add field selector to list experiments API #44
Merged
deadlycoconuts
merged 18 commits into
caraml-dev:main
from
deadlycoconuts:allow_changing_row_num_when_listing_exp
Nov 3, 2022
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
02a7571
Add field selector to list experiments API
deadlycoconuts 445de2f
Refactor experiment service by creating more helper functions
deadlycoconuts 1eeb15a
Specify table fields when UI queries API for experiments list
deadlycoconuts 4df309d
Fix refactoring changes
deadlycoconuts de9cf07
Update experiment context to query more experiments at once
deadlycoconuts 5d81cce
Remove all experiment fields from required field
deadlycoconuts e82df84
Make list experiments return paginated responses when page values are…
deadlycoconuts 5bccf98
Simplify api call to list experiments to only be performed once
deadlycoconuts 5fa5bd1
Fix changes to experiment models struct
deadlycoconuts 7a6872b
Update treatment service with changes to experiment model struct
deadlycoconuts 30302ec
Refactor pagination to only take place when fields are not specified
deadlycoconuts cec0c97
Fix bug whereby query fields were not passed to experiment service
deadlycoconuts 3822e92
Make api call to display number of experiments retrieve only 1 field
deadlycoconuts b7bccab
Simplify API calls to list experiments endpoint
deadlycoconuts 8c701c0
Fix bug whereby query fields were not passed to experiment service
deadlycoconuts f22bddc
Revert changes to experiments config group by modifying experiments c…
deadlycoconuts 09739a4
Refactor configs and contexts
deadlycoconuts c990155
Refactor fieldNamesSet by using imported set
deadlycoconuts File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the change in this PR, all fields from
Experiment
should be considered to be not required, like we do forTreatment
.