Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Fix retrieval of navigate function #53

Conversation

deadlycoconuts
Copy link
Contributor

@deadlycoconuts deadlycoconuts commented Dec 1, 2022

What this PR does / why we need it:
This PR fixes a tiny bug with the UI when a user is led to the landing page with a prompt to create new project settings for a project that has yet to be set up.

Upon clicking on the link in the prompt, the user would not get redirected correctly and nothing happens.

Screenshot 2022-12-01 at 5 51 46 PM

Which issue(s) this PR fixes:
This PR fixes the way in which the navigate function from the react-router-dom package gets retrieved.

@deadlycoconuts deadlycoconuts requested a review from a team December 1, 2022 09:55
@deadlycoconuts deadlycoconuts self-assigned this Dec 1, 2022
@deadlycoconuts deadlycoconuts changed the title Fix retrieval of navigate function Bugfix: Fix retrieval of navigate function Dec 1, 2022
@deadlycoconuts deadlycoconuts added the bug Something isn't working label Dec 1, 2022
@deadlycoconuts
Copy link
Contributor Author

Thanks for the quick approval! 🚀

@deadlycoconuts deadlycoconuts merged commit 7b92dfa into caraml-dev:main Dec 1, 2022
@deadlycoconuts deadlycoconuts deleted the fix_ui_create_project_settings_redirect branch December 2, 2022 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants