Bugfix: Make experiment runner return a 200 success code when no experiments are matched #62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
There is a bug in the
GetTreatmentForRequest
method of the XP plugin that causes it to return a 400 error when no experiments are matched for the given request. This PR introduces a tiny fix to change the response code to 200 when this happens, just like how this case (no experiments matched) is handled by the standalone Treatment Service (see analogous line here)