Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert PR (#70) - addition of gorm config to update nested fields in the db #71

Conversation

deadlycoconuts
Copy link
Contributor

What this PR does / why we need it:
This PR reverts the changes introduced in #71, as there is no need to enforce all associations of a Gorm object to be saved. A similar change was first introduced in caraml-dev/turing#331 but it has since been removed in favour of a more precise manner of updating tables that contain nested fields of a Gorm object.

Which issue(s) this PR fixes:

Fixes #

Copy link
Collaborator

@krithika369 krithika369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @deadlycoconuts !

@deadlycoconuts deadlycoconuts merged commit 8222a91 into caraml-dev:main Apr 18, 2023
@deadlycoconuts deadlycoconuts deleted the revert_addition_of_gorm_config_to_update_nested_fields branch August 1, 2023 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants