Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust width #91

Closed
mxstbr opened this issue Oct 2, 2017 · 6 comments
Closed

Adjust width #91

mxstbr opened this issue Oct 2, 2017 · 6 comments

Comments

@mxstbr
Copy link

mxstbr commented Oct 2, 2017 •
edited
Loading

I just generated this image:

carbon-1

It'd be great if:

  • I could make the font size bigger (ref Adjust font style #46)
  • but also if I could shrink the width of the code block manually (or it adjust automatically based on longest line)
@pa7ryk
Copy link
Contributor

pa7ryk commented Oct 3, 2017

Hi, I think I can give it a try.

@mfix22
Copy link
Contributor

mfix22 commented Oct 4, 2017

See #33 and #1 for discussion reference as well. I also believe @jakedex is working on font-size fix

@jakedex jakedex removed their assignment Oct 4, 2017
@pa7ryk
Copy link
Contributor

pa7ryk commented Oct 4, 2017

I can create new setting next to Window controlls which will enables automatic width adjust based on longest line. IMHO manual width adjustment is not a bare necessary thing. What do you think?

@mxstbr
Copy link
Author

mxstbr commented Oct 4, 2017

Agreed, automatic would be optimal.

@jakedex
Copy link
Collaborator

jakedex commented Oct 4, 2017

I'm totally fine with that. Automatic is a great start and we can leave #1 open in case someone wants to take a shot at manual.

jakedex pushed a commit that referenced this issue Oct 5, 2017
@pa7ryk @jakedex
Add width adjustment. (#91)
ede83bf
@jakedex
Copy link
Collaborator

jakedex commented Oct 5, 2017

Closed with #102. Thanks, @mxstbr @pa7ryk! 🎉

@jakedex jakedex closed this as completed Oct 5, 2017
@jakedex jakedex mentioned this issue Oct 5, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mxstbr @mfix22 @jakedex @pa7ryk