Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use .github for GitHub templates #92

Closed
yeskunall opened this issue Oct 2, 2017 · 4 comments
Closed

Use .github for GitHub templates #92

yeskunall opened this issue Oct 2, 2017 · 4 comments
Assignees

Comments

@yeskunall
Copy link
Contributor

yeskunall commented Oct 2, 2017

Maybe create a .github/ folder at this point, and move CONTRIBUTING.md inside it? Also, maybe create an ISSUE_TEMPLATE.md and PULL_REQUEST.md?

But most importantly, in lieu of #79, I was thinking that maybe we can add a CONTRIBUTORS.md inside .github/ and link it in README.md instead? This way the README itself doesn't have to get cluttered unnecessarily.

@jakedex
Copy link
Collaborator

jakedex commented Oct 2, 2017

Thanks for tackling this one, @yeskunall! I'm definitely on board with adding a .github folder, but I think we want to keep our contributors section in the README.md to make it as visible as possible. I'm all for moving it into a CONTRIBUTORS.md and linking down the road if it gets too cluttered.

See https://github.com/kentcdodds/all-contributors#mandatory

@yeskunall
Copy link
Contributor Author

Sure thing. This will make the build script a bit more tricky than it is right now, but I'll show you what I guys did in the PR.

Once that's approved, a PR for creating a .github folder will be up as well.

Cheers! ❤️

@yeskunall
Copy link
Contributor Author

At work. No worries tho, this will definitely have a PR by today evening. Should we also introduce basic templates for issues and PRs?

@jakedex
Copy link
Collaborator

jakedex commented Oct 5, 2017

No rush! And yeah, let's add templates for both.

@jakedex jakedex closed this as completed in 722ac89 Oct 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants