Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Translation/traditional chinese #1229

Merged
merged 3 commits into from
Aug 16, 2021

Conversation

kewang
Copy link
Contributor

@kewang kewang commented Jul 4, 2021

  • Integration tests (if applicable)

Closes #

@mfix22
Copy link
Contributor

mfix22 commented Aug 14, 2021

Hi @kewang  — i'm not sure if you are trying to add a new translation, or replace the existing one. It is not clear from the description.
If you want to add a new translation, please add new README files and don't edit existing ones. Thanks!

@mfix22 mfix22 closed this Aug 14, 2021
@kewang
Copy link
Contributor Author

kewang commented Aug 15, 2021

Hi @mfix22

I just want to update current 臺灣 translation, and 臺灣 is a place name, not a language name.

So I also update README.md language name.

@kewang kewang changed the title Translation/traditional chinese Update Translation/traditional chinese Aug 15, 2021
@mfix22 mfix22 reopened this Aug 16, 2021
@mfix22 mfix22 force-pushed the translation/traditional-chinese branch from 28a2b2b to 80240e3 Compare August 16, 2021 01:30
@mfix22 mfix22 merged commit b2e251f into carbon-app:main Aug 16, 2021
@mfix22 mfix22 added the translator Mark contributor as a translator label Aug 16, 2021
@repo-ranger
Copy link
Contributor

repo-ranger bot commented Aug 16, 2021

@all-contributors add @kewang for translation

@allcontributors
Copy link
Contributor

@repo-ranger[bot]

@kewang already contributed before to translation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translator Mark contributor as a translator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants