Adding drop shadow offset-y and blur-radius menu option #143
Conversation
There was a problem hiding this comment.
Thanks for the PR, @rafaelcamaram. Outside of my requested changes, it looks great!
components/Carbon.js
Outdated
| @@ -107,7 +109,9 @@ class Carbon extends React.Component { | |||
| <div id="container"> | |||
| {config.windowControls ? <WindowControls theme={config.windowTheme} /> : null} | |||
| <CodeMirror | |||
| className={`CodeMirror__container window-theme__${config.windowTheme}`} | |||
| className={`CodeMirror__container CodeMirror__shadow window-theme__${ | |||
There was a problem hiding this comment.
I don't think we need to add a new class (CodeMirror__shadow) here?
components/Carbon.js
Outdated
| } | ||
|
|
||
| #container :global(.CodeMirror__shadow) { | ||
| ${config.dropShadow |
There was a problem hiding this comment.
Let's use template literals here
components/Settings.js
Outdated
| @@ -44,6 +44,16 @@ class Settings extends React.Component { | |||
| enabled={this.props.enabled.dropShadow} | |||
| onChange={this.props.onChange.bind(null, 'dropShadow')} | |||
| /> | |||
| <Slider | |||
| label="Drop shadow offset-y" | |||
There was a problem hiding this comment.
I think we should change these to 'Drop shadow (offset-y)' to be consistent with Padding (verticle), etc.
|
Hey @rafaelcamaram, could you address the concerns @jakedex mentioned? |
components/Settings.js
Outdated
| onChange={this.props.onChange.bind(null, 'dropShadowOffsetY')} | ||
| /> | ||
| <Slider | ||
| label="Drop shadow blur-radius" |
There was a problem hiding this comment.
Please make this one "Drop shadow (blur-radius)"
|
Thanks @rafaelcamaram, just one more thing! |
|
@mfix22 Done! :) |
|
Thanks so much for the help @rafaelcamaram. Just released with your changes https://github.com/dawnlabs/carbon/releases/tag/1.0.4 |
Adding the option that allows the user to change the
box-shadowoffset-y and blur-radius properties.