Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LineGraph uses unsafe methods, producing warnings #144

Open
s100 opened this issue Aug 22, 2019 · 0 comments
Open

LineGraph uses unsafe methods, producing warnings #144

s100 opened this issue Aug 22, 2019 · 0 comments

Comments

@s100
Copy link
Contributor

s100 commented Aug 22, 2019

Detailed description

Is this issue related to a specific component?

<LineGraph>

What did you expect to happen? What happened instead? What would you like to see changed?

I expected to be able to use <LineGraph> without warnings appearing in my console. However, I see two warnings about the use of unsafe methods componentWillReceiveProps and componentWillUpdate:

Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See https://fb.me/react-async-component-lifecycle-hooks for details.

* Move data fetching code or side effects to componentDidUpdate.
* If you're updating state whenever props change, refactor your code to use memoization techniques or move it to static getDerivedStateFromProps. Learn more at: https://fb.me/react-derived-state
* Rename componentWillReceiveProps to UNSAFE_componentWillReceiveProps to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.

Please update the following components: LineGraph

and

Warning: componentWillUpdate has been renamed, and is not recommended for use. See https://fb.me/react-async-component-lifecycle-hooks for details.

* Move data fetching code or side effects to componentDidUpdate.
* Rename componentWillUpdate to UNSAFE_componentWillUpdate to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.

Please update the following components: LineGraph

What browser are you working in?

Chrome 76.0.3809.100 64-bit on Windows 10

What version of the Carbon Design System are you using?

This is carbon-addons-data-viz-react@1.22.0, the latest available at the time of writing.

Steps to reproduce the issue

Basically just inspecting the code of <LineGraph> will demonstrate this issue!

Additional information

This is with React 16.9.0.

Add labels

It looks like I don't have permission to label this issue myself, but I would categorise it as a high-priority chore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant