Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repo] enforce classnames import name format via eslint rule #1325

Open
soniadeveloper opened this issue Jun 18, 2020 · 1 comment
Open

[repo] enforce classnames import name format via eslint rule #1325

soniadeveloper opened this issue Jun 18, 2020 · 1 comment

Comments

@soniadeveloper
Copy link
Contributor

Summary

The classnames import was updated so each instance of it in every file has the same import name. For example, whenever classnames is imported it should be imported as
import classnames from 'classnames'
However, there should be an ESLint rule that produces an error when an import uses a name that isn't approved in order to maintain consistency.

Additional context
See issue #799

@soniadeveloper soniadeveloper added the type: enhancement 💡 New feature or request label Jun 18, 2020
@tay1orjones tay1orjones changed the title [Repo] Make Classnames Import Consistent [repo] enforce classnames import name format via eslint rule Jun 18, 2020
@soniadeveloper soniadeveloper self-assigned this Jun 18, 2020
@davidicus davidicus added this to the Sprint 52 milestone Jul 20, 2020
@soniadeveloper
Copy link
Contributor Author

According to this issue: import-js/eslint-plugin-import#1143 there is a linting rule in the making that will accomplish what we need

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants