Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(prettier): downgrade for now #1621

Conversation

nstuyvesant
Copy link
Contributor

Updates

  • Downgrade to prettier 2.8.8 due to prettier-plugin-svelte (lerna issue is resolved).

@nstuyvesant nstuyvesant requested review from theiliad, Akshat55 and a team as code owners July 14, 2023 03:15
@nstuyvesant nstuyvesant requested review from zvonimirfras and removed request for a team July 14, 2023 03:15
@netlify
Copy link

netlify bot commented Jul 14, 2023

Deploy Preview for carbon-charts-react ready!

Name Link
🔨 Latest commit 8a867a4
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-react/deploys/64b0bf96700daa0008b3015d
😎 Deploy Preview https://deploy-preview-1621--carbon-charts-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 14, 2023

Deploy Preview for carbon-charts-angular ready!

Name Link
🔨 Latest commit 8a867a4
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-angular/deploys/64b0bf969af51e00086a1d2b
😎 Deploy Preview https://deploy-preview-1621--carbon-charts-angular.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 14, 2023

Deploy Preview for carbon-charts-core ready!

Name Link
🔨 Latest commit 8a867a4
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-core/deploys/64b0bf96ce335b00088762a2
😎 Deploy Preview https://deploy-preview-1621--carbon-charts-core.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@theiliad theiliad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theiliad theiliad merged commit 22509a2 into carbon-design-system:master Jul 14, 2023
4 checks passed
@theiliad theiliad deleted the downgrade-prettier-due-to-prettier-plugin-svelte branch July 14, 2023 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants