Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lerna version): hoist prettier-plugin-svelte due to lerna bug #1628

Merged

Conversation

nstuyvesant
Copy link
Contributor

Updates

  • lerna version has some checks for prettier for some unknown reason. One of those checks is to look for prettier-plugin-svelte in the top-level node_modules. But it normally resides in packages/svelte/node_modules. This update adds it as a devDependency to the top-level package.json to force it to be hoisted.
  • An issue has been opened on Lerna's GitHub to get the problem corrected.

@nstuyvesant nstuyvesant requested review from theiliad, Akshat55 and a team as code owners July 20, 2023 16:39
@nstuyvesant nstuyvesant requested review from zvonimirfras and removed request for a team July 20, 2023 16:39
@netlify
Copy link

netlify bot commented Jul 20, 2023

Deploy Preview for carbon-charts-core ready!

Name Link
🔨 Latest commit 78cad3f
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-core/deploys/64b9635ebd03540008ec4486
😎 Deploy Preview https://deploy-preview-1628--carbon-charts-core.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 20, 2023

Deploy Preview for carbon-charts-react ready!

Name Link
🔨 Latest commit 78cad3f
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-react/deploys/64b9635e8ddd3300089fbb07
😎 Deploy Preview https://deploy-preview-1628--carbon-charts-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 20, 2023

Deploy Preview for carbon-charts-angular ready!

Name Link
🔨 Latest commit 78cad3f
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-angular/deploys/64b9635e3a1e520008a2fce9
😎 Deploy Preview https://deploy-preview-1628--carbon-charts-angular.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@theiliad theiliad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try it

@theiliad theiliad merged commit ced7b9e into carbon-design-system:master Jul 20, 2023
4 checks passed
@theiliad theiliad deleted the hoist-prettier-plugin-svelte branch July 20, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants