Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core,react,vue): misnamed entry points generated by vite #1708

Merged
merged 8 commits into from
Dec 27, 2023

Conversation

nstuyvesant
Copy link
Contributor

@nstuyvesant nstuyvesant commented Dec 26, 2023

Updates

  • Fixes issue where generated entry point for @carbon/react and @carbon/vue were index.mjs.js instead of index.js
  • Fixes issue where generated entry point for @carbon/charts UMD file was misnamed
  • Minor bumps for publint, @nrwl/devkit, vite-plugin-dts, eslint-plugin-prettier, classnames, @vitejs/plugin-vue, vue-tsc
  • Closes [Bug]: Broken link in docs #1687

@nstuyvesant nstuyvesant requested review from theiliad and a team as code owners December 26, 2023 14:29
Copy link

netlify bot commented Dec 26, 2023

Deploy Preview for carbon-charts-angular ready!

Name Link
🔨 Latest commit 8f6b42f
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-angular/deploys/658afc19ee31f700085d3857
😎 Deploy Preview https://deploy-preview-1708--carbon-charts-angular.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 26, 2023

Deploy Preview for carbon-charts-react ready!

Name Link
🔨 Latest commit 8f6b42f
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-react/deploys/658afc192eb20800089ef904
😎 Deploy Preview https://deploy-preview-1708--carbon-charts-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 26, 2023

Deploy Preview for carbon-charts-core ready!

Name Link
🔨 Latest commit 8f6b42f
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-core/deploys/658afc192cd6e300087a17b4
😎 Deploy Preview https://deploy-preview-1708--carbon-charts-core.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nstuyvesant nstuyvesant changed the title fix(react,vue): generated entry points were index.mjs.js - not index.js fix(core,react,vue): misnamed entry points generated by vite Dec 26, 2023
@theiliad theiliad merged commit 882bf01 into carbon-design-system:master Dec 27, 2023
4 checks passed
@theiliad theiliad deleted the fix-vite-react-vue branch December 27, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Broken link in docs
2 participants