Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modal): padding of export to csv button #1748

Conversation

markchou0225
Copy link
Contributor

@markchou0225 markchou0225 commented Feb 8, 2024

Closes #1730

Updates

  • Fix padding-inline-start and padding-inline-end of export to csv button.

Demo screenshot or recording

Add the missing variable for padding of button

Screenshot 2024-02-08 at 11 14 46 PM Screenshot 2024-02-08 at 11 15 15 PM

@markchou0225 markchou0225 requested review from theiliad and a team as code owners February 8, 2024 14:56
Copy link

netlify bot commented Feb 8, 2024

Deploy Preview for carbon-charts-angular ready!

Name Link
🔨 Latest commit 1be5a5d
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-angular/deploys/65c4ebaddbffb10008b367a9
😎 Deploy Preview https://deploy-preview-1748--carbon-charts-angular.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 8, 2024

Deploy Preview for carbon-charts-react ready!

Name Link
🔨 Latest commit 1be5a5d
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-react/deploys/65c4ebad71caac0008c43138
😎 Deploy Preview https://deploy-preview-1748--carbon-charts-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 8, 2024

Deploy Preview for carbon-charts-core ready!

Name Link
🔨 Latest commit 1be5a5d
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-core/deploys/65c4ebadf55695000874b5d6
😎 Deploy Preview https://deploy-preview-1748--carbon-charts-core.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@theiliad theiliad added the type: bug 🐛 Something isn't working label Feb 8, 2024
@theiliad theiliad merged commit aa3caba into carbon-design-system:master Feb 8, 2024
4 checks passed
@markchou0225 markchou0225 deleted the bug/1730-button-padding-in-modal branch February 28, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Broken style for "Download as CSV" button in tabular representation
2 participants