Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tabular-rep): better handling of null values #1779

Merged

Conversation

RiyaJethwa
Copy link
Contributor

@RiyaJethwa RiyaJethwa commented Mar 8, 2024

Updates

Demo screenshot or recording

image

@RiyaJethwa RiyaJethwa requested review from theiliad and a team as code owners March 8, 2024 10:48
Copy link

netlify bot commented Mar 8, 2024

Deploy Preview for carbon-charts-angular ready!

Name Link
🔨 Latest commit 1b5a867
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-angular/deploys/65eaed134a742a00082ce589
😎 Deploy Preview https://deploy-preview-1779--carbon-charts-angular.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 8, 2024

Deploy Preview for carbon-charts-core ready!

Name Link
🔨 Latest commit 1b5a867
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-core/deploys/65eaed13a3b71500080972ee
😎 Deploy Preview https://deploy-preview-1779--carbon-charts-core.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@RiyaJethwa
Copy link
Contributor Author

I have read the DCO document and I hereby sign the DCO.

Copy link

netlify bot commented Mar 8, 2024

Deploy Preview for carbon-charts-react ready!

Name Link
🔨 Latest commit 1b5a867
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-react/deploys/65eaed13c5c50e00076c794f
😎 Deploy Preview https://deploy-preview-1779--carbon-charts-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@theiliad theiliad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theiliad theiliad changed the title Heatmap data value null fallback fix(tabular-rep): better handling of null values Mar 8, 2024
@theiliad theiliad merged commit 011f3b4 into carbon-design-system:master Mar 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants