Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Redefined variables violating no-shadow rule #1850

Closed
1 of 6 tasks
nstuyvesant opened this issue Jun 15, 2024 · 0 comments · Fixed by #1851
Closed
1 of 6 tasks

[Bug]: Redefined variables violating no-shadow rule #1850

nstuyvesant opened this issue Jun 15, 2024 · 0 comments · Fixed by #1851

Comments

@nstuyvesant
Copy link
Contributor

Relevant package(s)

  • @carbon/charts
  • @carbon/charts-svelte
  • @carbon/charts-react
  • @carbon/charts-angular
  • @carbon/charts-vue
  • Documentation website

Carbon Charts Version

1.16.7

Which bundler are you using?

Vite

What happened and what did you expect to happen?

Eslint identified 4 bugs in core:

  1. packages/core/src/selectedGroups.spec.ts - prefix is imported but then redefined
  2. packages/core/src/components/graphs/gauge.ts - value const defined on line 170 then redefined in arrow function on line 214
  3. packages/core/src/components/graphs/heatmap.ts - domainIdentifier const defined on line 58 then redefined in arrow function on 116
  4. packages/core/src/components/graphs/radar.ts - const data defined on line 54 and arrow function parameter of same name defined on line 97

Chart data and options (automatically formatted so no need for backticks)

N/A

JavaScript console or build output (if relevant)

N/A

StackBlitz repro

No response

IBM Application/Team (if relevant)

No response

What priority level would this be in your opinion?

P1 (High)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant