Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skeleton charts & empty states #407

Closed
1 of 5 tasks
pcoccoli opened this issue Nov 18, 2019 · 15 comments · Fixed by #555
Closed
1 of 5 tasks

Skeleton charts & empty states #407

pcoccoli opened this issue Nov 18, 2019 · 15 comments · Fixed by #555

Comments

@pcoccoli
Copy link

I am submitting a...

  • Feature request
  • Design defect
  • Source code defect
  • Demo/documentation defect
  • Other

charts version:

0.16.24

Issue description

My project requires UI "skeletons" while data is loading.

@theiliad
Copy link
Member

theiliad commented Dec 2, 2019

There have been explorations on empty states and skeletons.

Nothing that's been approved so far, I will bring up with design, thanks 🙂

@theiliad theiliad changed the title Skeleton charts Skeleton charts & empty states Feb 5, 2020
@theiliad theiliad added contributor: accurat Work contributed by accurat severity: 1 Must be fixed ASAP labels Feb 5, 2020
@theiliad theiliad added this to ToDos in Accurat via automation Feb 5, 2020
@theiliad
Copy link
Member

theiliad commented Feb 5, 2020

Minor explorations by Shixie
image

@gvnmagni
Copy link

Hello! We are working on the empty states for the different typologies of charts. Attached you can find a preview (sorry for the quite long image), we'd love to get a feedback on a detail.

As you can see for each chart we made two option and the difference is just in the color, second option include a light red for chart structure/grid.

This two states could become one, or they could be 2 option for 2 specific cases:

  • Grey option / When data is loading
  • Red option / When data are not available or there are issues

Using a light red could be interesting to point out errors or issues, what do you think @theiliad?

empty_states

@theiliad
Copy link
Member

LGTM @gvnmagni. I like the red versions as well although I don't see a necessity for that, the lack of a chart being rendered should be alarming enough to the user/developer.

@ninja511 ninja511 moved this from ToDos to In progress in Accurat Feb 24, 2020
@gvnmagni
Copy link

Thanks Iliad, @mjabbink any preference on this? We are totally ok with both options, just wanted to understand if we like the idea of using a bit of red to give a little alarm when there are issues or if we prefer to just use the grey which might be more neutral

@mjabbink
Copy link

agree no red as I think that over emphasizes the issue. Belt and suspenders.

@stegue88
Copy link

stegue88 commented Mar 6, 2020

Hi all, please find attached the Sketch file with the design specs.
Let me know if you prefer to receive directly svgs or something else instead.
200306_skeleton_emptystates.zip

@theiliad
Copy link
Member

theiliad commented Mar 6, 2020

Hi all, please find attached the Sketch file with the design specs.
Let me know if you prefer to receive directly svgs or something else instead.
200306_skeleton_emptystates.zip

LGTM 💯

@ilariaventurini
Copy link
Contributor

Hello everyone! We did two simple tests with missing data (ie data = { datasets: [], labels: [] }) for scatterplot and stackedbar.

Attached you can find two gifs that show the animation between missing data and correct data (the idea is simulate the data loading).

scatterplot
stackedbar

Do you think they can be fine?

@theiliad
Copy link
Member

Do you think they can be fine?

looks great to me 💯

@theiliad
Copy link
Member

theiliad commented Mar 16, 2020

One comment I have is that if the legend disappears then the chart should probably take the rest of the height of the container (I believe if legend renders nothing then the layout component would automatically do that)

@gvnmagni
Copy link

Russ, this image includes all the empty states from the design side. Development is almost done (we are evaluating what to do with skeleton, if it's worth to put some effort on it, but this is now a different issue)

empty states

@anne-stevens
Copy link

Here are some examples of empty state placeholders, loader states (the shimmer) and entry animation patterns from Cognos Analytics. (Note that the first couple of example take a long time to load b/c they are from a slow test environment.)

Cognos - empty state and shimmer 1.mov.zip
Cognos - empty state and shimmer 2b.mov.zip
Cognos - entry animation 3.mov.zip
Cognos - empty state and entry animation 4.mov.zip

@theiliad
Copy link
Member

Here are some examples of empty state placeholders, loader states (the shimmer) and entry animation patterns from Cognos Analytics. (Note that the first couple of example take a long time to load b/c they are from a slow test environment.)

Cognos - empty state and shimmer 1.mov.zip
Cognos - empty state and shimmer 2b.mov.zip
Cognos - entry animation 3.mov.zip
Cognos - empty state and entry animation 4.mov.zip

@anne-stevens have you done user testing for any of these skeleton components?

They seem highly inconsistent with the real chart that's rendered afterwards.

Overall I think it's a bit loud on the screen

@caesarsol
Copy link
Contributor

Just created #568 to track the error states. They are considered external to this task.

@ninja511 ninja511 moved this from In progress to QA/Review in Accurat Apr 27, 2020
Accurat automation moved this from QA/Review to Closed May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Accurat
  
Closed
Development

Successfully merging a pull request may close this issue.

8 participants