-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skeleton charts & empty states #407
Comments
There have been explorations on empty states and skeletons. Nothing that's been approved so far, I will bring up with design, thanks 🙂 |
Hello! We are working on the empty states for the different typologies of charts. Attached you can find a preview (sorry for the quite long image), we'd love to get a feedback on a detail. As you can see for each chart we made two option and the difference is just in the color, second option include a light red for chart structure/grid. This two states could become one, or they could be 2 option for 2 specific cases:
Using a light red could be interesting to point out errors or issues, what do you think @theiliad? |
LGTM @gvnmagni. I like the red versions as well although I don't see a necessity for that, the lack of a chart being rendered should be alarming enough to the user/developer. |
Thanks Iliad, @mjabbink any preference on this? We are totally ok with both options, just wanted to understand if we like the idea of using a bit of red to give a little alarm when there are issues or if we prefer to just use the grey which might be more neutral |
agree no red as I think that over emphasizes the issue. Belt and suspenders. |
Hi all, please find attached the Sketch file with the design specs. |
LGTM 💯 |
looks great to me 💯 |
One comment I have is that if the legend disappears then the chart should probably take the rest of the height of the container (I believe if legend renders nothing then the layout component would automatically do that) |
Here are some examples of empty state placeholders, loader states (the shimmer) and entry animation patterns from Cognos Analytics. (Note that the first couple of example take a long time to load b/c they are from a slow test environment.) Cognos - empty state and shimmer 1.mov.zip |
@anne-stevens have you done user testing for any of these skeleton components? They seem highly inconsistent with the real chart that's rendered afterwards. Overall I think it's a bit loud on the screen |
Just created #568 to track the error states. They are considered external to this task. |
I am submitting a...
charts version:
0.16.24
Issue description
My project requires UI "skeletons" while data is loading.
The text was updated successfully, but these errors were encountered: