Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UIShell components: rename "isOpen" prop to "open" #461

Open
Tracked by #1621
weaseldotro opened this issue Dec 11, 2020 · 0 comments
Open
Tracked by #1621

UIShell components: rename "isOpen" prop to "open" #461

weaseldotro opened this issue Dec 11, 2020 · 0 comments

Comments

@weaseldotro
Copy link
Contributor

weaseldotro commented Dec 11, 2020 •
edited

The isOpen prop should be renamed to open in the UIShell components: HeaderAction, HamburgerMenu, SideNav.

This would be a breaking change for apps currently using these components, but would improve consistency in prop naming with the rest of the library. There are only 3 components using isOpen, while 11 other components use open.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@weaseldotro