Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(content-switcher): add shadow parts #11904

Merged
merged 3 commits into from
Jul 8, 2024
Merged

feat(content-switcher): add shadow parts #11904

merged 3 commits into from
Jul 8, 2024

Conversation

Valentin-Sorin-Nicolae
Copy link
Contributor

ADCMS-5315

Description

All non-slot elements in the shadow DOM should be given a unique "part" name allowing CSS to target and override component default styles. This is for the "content-switcher" component.

Changelog

New

Adding the shadow parts for the "content-switcher" component and documentation.

@Valentin-Sorin-Nicolae Valentin-Sorin-Nicolae requested a review from a team as a code owner July 3, 2024 11:34
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jul 3, 2024 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11904/index.html

Built with commit: 9b2d96117dbe8a85de54a450fd39b69d2048465a

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jul 3, 2024 •
edited
Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11904/index.html

Built with commit: 9b2d96117dbe8a85de54a450fd39b69d2048465a

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jul 3, 2024 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11904/index.html

Built with commit: 9b2d96117dbe8a85de54a450fd39b69d2048465a

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jul 3, 2024 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11904/index.html

Built with commit: 9b2d96117dbe8a85de54a450fd39b69d2048465a

m4olivei
m4olivei requested changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@m4olivei m4olivei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small item missed. See comment.

packages/carbon-web-components/src/components/content-switcher/content-switcher-item.ts
@@ -133,6 +136,7 @@ export default class CDSContentSwitcherItem extends FocusMixin(LitElement) {
type="button"
role="tab"
class="${className}"
part="button"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. There is also a child <span> element that needs a part name as well. Probably label makes sense as a name for that one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thanks!

m4olivei
m4olivei approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@m4olivei m4olivei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just pushed a quick commit to cover the docs for the added label shadow part. All set.

@m4olivei m4olivei merged commit df3171c into carbon-design-system:feat/v2-shadow-parts Jul 8, 2024
6 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4olivei m4olivei m4olivei approved these changes

@bruno-amorim bruno-amorim Awaiting requested review from bruno-amorim

@marcelojcs marcelojcs Awaiting requested review from marcelojcs

@andy-blum andy-blum Awaiting requested review from andy-blum

Assignees
No one assigned
Labels
shadow parts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Valentin-Sorin-Nicolae @ibmdotcom-bot @m4olivei