Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(chat-button): add shadow parts #11906

Merged
merged 1 commit into from
Jul 4, 2024
Merged

feat(chat-button): add shadow parts #11906

merged 1 commit into from
Jul 4, 2024

Conversation

Valentin-Sorin-Nicolae
Copy link
Contributor

ADCMS-5311

Description

All non-slot elements in the shadow DOM should be given a unique "part" name allowing CSS to target and override component default styles. This is for the "chat-button" component.

Changelog

New

Adding the shadow parts for the "chat-button" component and documentation.

@Valentin-Sorin-Nicolae Valentin-Sorin-Nicolae requested a review from a team as a code owner July 4, 2024 10:31
@Valentin-Sorin-Nicolae Valentin-Sorin-Nicolae requested review from ariellalgilmore and IgnacioBecerra and removed request for a team July 4, 2024 10:31
@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11906/index.html

Built with commit: 049cc5f1df1903e343b8da93de21dd55b6e82b10

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11906/index.html

Built with commit: 049cc5f1df1903e343b8da93de21dd55b6e82b10

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11906/index.html

Built with commit: 049cc5f1df1903e343b8da93de21dd55b6e82b10

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11906/index.html

Built with commit: 049cc5f1df1903e343b8da93de21dd55b6e82b10

@m4olivei m4olivei merged commit 17c6d61 into carbon-design-system:feat/v2-shadow-parts Jul 4, 2024
12 of 21 checks passed
@Valentin-Sorin-Nicolae Valentin-Sorin-Nicolae deleted the chat-button-shadow-part branch July 5, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4olivei m4olivei m4olivei approved these changes

@bruno-amorim bruno-amorim Awaiting requested review from bruno-amorim

@marcelojcs marcelojcs Awaiting requested review from marcelojcs

@andy-blum andy-blum Awaiting requested review from andy-blum

Assignees
No one assigned
Labels
shadow parts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Valentin-Sorin-Nicolae @ibmdotcom-bot @m4olivei