Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(combobox): adding shadow parts #11913

Merged
merged 2 commits into from
Jul 8, 2024
Merged

feat(combobox): adding shadow parts #11913

merged 2 commits into from
Jul 8, 2024

Conversation

bruno-amorim
Copy link
Contributor

Related Ticket(s)

ADCMS-5314

Description

Adding CSS Shadow Parts to v2 components to allow light customizations to component internals.

@bruno-amorim bruno-amorim requested a review from a team as a code owner July 8, 2024 19:20
@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11913/index.html

Built with commit: 3d8574af65ce58a95695f06954fa97dd447f3d76

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11913/index.html

Built with commit: 3d8574af65ce58a95695f06954fa97dd447f3d76

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11913/index.html

Built with commit: 3d8574af65ce58a95695f06954fa97dd447f3d76

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11913/index.html

Built with commit: 3d8574af65ce58a95695f06954fa97dd447f3d76

m4olivei
m4olivei approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@m4olivei m4olivei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@m4olivei m4olivei merged commit b4321a1 into feat/v2-shadow-parts Jul 8, 2024
17 of 32 checks passed
@m4olivei m4olivei deleted the feat/combobox-shadow-parts branch July 8, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4olivei m4olivei m4olivei approved these changes

@marcelojcs marcelojcs Awaiting requested review from marcelojcs

@andy-blum andy-blum Awaiting requested review from andy-blum

@Valentin-Sorin-Nicolae Valentin-Sorin-Nicolae Awaiting requested review from Valentin-Sorin-Nicolae

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bruno-amorim @ibmdotcom-bot @m4olivei