Skip to content

Commit

Permalink
fix(ui-shell): display names for HeaderMenu & SideNavMenu forwardRefs (
Browse files Browse the repository at this point in the history
  • Loading branch information
jendowns authored and asudoh committed Nov 20, 2019
1 parent 573a103 commit 6a0cfea
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 4 deletions.
5 changes: 4 additions & 1 deletion packages/react/src/components/UIShell/HeaderMenu.js
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,9 @@ class HeaderMenu extends React.Component {
};
}

export default React.forwardRef((props, ref) => {
const HeaderMenuForwardRef = React.forwardRef((props, ref) => {
return <HeaderMenu {...props} focusRef={ref} />;
});

HeaderMenuForwardRef.displayName = 'HeaderMenu';
export default HeaderMenuForwardRef;
5 changes: 4 additions & 1 deletion packages/react/src/components/UIShell/SideNavMenu.js
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,9 @@ export class SideNavMenu extends React.Component {
}
}

export default React.forwardRef((props, ref) => {
const SideNavMenuForwardRef = React.forwardRef((props, ref) => {
return <SideNavMenu {...props} buttonRef={ref} />;
});

SideNavMenuForwardRef.displayName = 'SideNavMenu';
export default SideNavMenuForwardRef;
4 changes: 4 additions & 0 deletions packages/react/src/components/UIShell/UIShell-story.js
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,10 @@ import {
SwitcherDivider,
} from '../UIShell';

SideNav.displayName = 'SideNav';
SideNavMenu.displayName = 'SideNavMenu';
SideNavMenuItem.displayName = 'SideNavMenuItem';

const Fade16 = () => (
<svg
width="16"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`HeaderMenu should render 1`] = `
<ForwardRef>
<HeaderMenu>
<HeaderMenu
focusRef={null}
renderMenuContent={[Function]}
Expand Down Expand Up @@ -153,5 +153,5 @@ exports[`HeaderMenu should render 1`] = `
</ul>
</li>
</HeaderMenu>
</ForwardRef>
</HeaderMenu>
`;

0 comments on commit 6a0cfea

Please sign in to comment.