Skip to content

Commit

Permalink
fix(selectable-tile): change divs inside label to span (#4745)
Browse files Browse the repository at this point in the history
  • Loading branch information
abbeyhrt authored and asudoh committed Nov 25, 2019
1 parent 20598c8 commit d7ac8fa
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions packages/react/src/components/RadioTile/RadioTile.js
Original file line number Diff line number Diff line change
Expand Up @@ -120,12 +120,12 @@ export default class RadioTile extends React.Component {
className={classes}
tabIndex={this.props.tabIndex}
onKeyDown={this.handleKeyDown}>
<div className={`${prefix}--tile__checkmark`}>
<span className={`${prefix}--tile__checkmark`}>
<CheckmarkFilled aria-label={iconDescription}>
{iconDescription && <title>{iconDescription}</title>}
</CheckmarkFilled>
</div>
<div className={`${prefix}--tile-content`}>{children}</div>
</span>
<span className={`${prefix}--tile-content`}>{children}</span>
</label>
</>
);
Expand Down
6 changes: 3 additions & 3 deletions packages/react/src/components/Tile/Tile.js
Original file line number Diff line number Diff line change
Expand Up @@ -339,12 +339,12 @@ export class SelectableTile extends Component {
{...other}
onClick={this.handleClick}
onKeyDown={this.handleKeyDown}>
<div className={`${prefix}--tile__checkmark`}>
<span className={`${prefix}--tile__checkmark`}>
<CheckmarkFilled aria-label={iconDescription}>
{iconDescription && <title>{iconDescription}</title>}
</CheckmarkFilled>
</div>
<div className={`${prefix}--tile-content`}>{children}</div>
</span>
<span className={`${prefix}--tile-content`}>{children}</span>
</label>
</>
);
Expand Down

0 comments on commit d7ac8fa

Please sign in to comment.