Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip - missing isVisible/controlled tooltip functionality from ap-components-react #2614

Closed
tomkdgun opened this issue Aug 21, 2018 · 10 comments
Labels

Comments

@tomkdgun
Copy link

Tooltip - missing isVisible/controlled tooltip functionality from ap-components-react

Detailed description

We currently using ap-components-react, and we need to migrate to carbon-components-react.
We have around 600 inputs across 230 files, which are wrapped by ap-components-react Tooltip, with isVisible, nowrap and hideOnHover properties.

In case of error in input field, error/validation message is displayed as tooltip, and hidden when value is correct, or displayed always during input modification. The tooltip is used, since input fields are in general to narrow to display any message inside or under the input. The hideOnHover sets pointer-events: none.

image

Currently we are relay on controlled Tooltips from ap-components-react.

Without this isVisible/controlled tooltip functionality, it will be difficult to perform migration.

@joshblack
Copy link
Contributor

Hi @tomkdgun! 👋 Am including our designers to weigh in on this 😄

cc @IBM/carbon-designers is this something that we should support?

@aagonzales
Copy link
Member

aagonzales commented Aug 23, 2018

We have a similar tooltip pattern in out Data tables for edit mode. I think the tooltip is a fair responsive solution for small fields however on larger fields if there is room to show the message below the field I think its is better ux practice to show it that to hide it in a tooltip.

We also had the another team (Functions I think) ask about adding the error icon inline to the normal invalid state which would help connect these two patterns more) #956

asudoh referenced this issue in asudoh/carbon-components Sep 13, 2018
Refs IBM/carbon-components-react#1213.
asudoh referenced this issue in asudoh/carbon-components Sep 13, 2018
Refs IBM/carbon-components-react#1213.
@stale
Copy link

stale bot commented May 2, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. Thanks for your contributions.

@carbon-bot carbon-bot transferred this issue from carbon-design-system/carbon-components-react May 9, 2019
@project-bot project-bot bot added this to Issue: needs triage 💊 in Carbon support May 9, 2019
@carbon-bot
Copy link
Contributor

Hi there! 👋 If you're wondering why this issue was moved, we're currently updating our repo structure so that every package is found in the same project.

This should not have any impact for you, but we wanted to give you a heads up in case you were wondering what is going on. If you have any questions, feel free to reach out to us on Slack or contact us at: carbon@us.ibm.com. Thanks!

@dakahn dakahn removed this from Issue: needs triage 💊 in Carbon support May 14, 2019
@stale
Copy link

stale bot commented Jun 8, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

1 similar comment
@stale
Copy link

stale bot commented Jul 8, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the status: inactive Will close if there's no further activity within a given time label Jul 8, 2019
@tomkdgun
Copy link
Author

It seems new Tooltip has open prop, which should allow achieve a goal. Unfortunately prop doesn't work as expected, and this blocking issue is still not fixed: #2849.
Please address #2849 and this one will be fixed.

@stale stale bot removed the status: inactive Will close if there's no further activity within a given time label Jul 11, 2019
@stale
Copy link

stale bot commented Aug 10, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the status: inactive Will close if there's no further activity within a given time label Aug 10, 2019
@tomkdgun
Copy link
Author

Please address #2849, and I will close this.

@stale stale bot removed the status: inactive Will close if there's no further activity within a given time label Aug 12, 2019
@tomkdgun
Copy link
Author

Closing since #2849 should fix this issue. In case of problems I will open new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants