Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal body overflows unexpectedly and scroll bar is not in container #3412

Closed
joshblack opened this issue Jul 16, 2019 · 6 comments · Fixed by #3607
Closed

Modal body overflows unexpectedly and scroll bar is not in container #3412

joshblack opened this issue Jul 16, 2019 · 6 comments · Fixed by #3607
Assignees

Comments

@joshblack
Copy link
Contributor

We recently had a user report that detailed that the modal body overflows unexpectedly, and the resulting scroll bar is also placed in an awkward location:

image

https://slkm7.codesandbox.io/

Can reproduce on latest Chrome.

@project-bot project-bot bot added this to Issue: needs triage 💊 in Carbon support Jul 16, 2019
@asudoh
Copy link
Contributor

asudoh commented Jul 17, 2019

@carbon-design-system/design Seems that modal content currently takes up 3/4 of the modal width, wondering if it makes sense to extend it to 100%. Any thoughts?

@elizabethsjudd
Copy link
Contributor

Here is the design I got from Anna wrt to scrolling/focusing the container in the modal. Looks like the content area needs to have padding instead of a margin

@jeanservaas
Copy link
Contributor

@asudoh the content only spans 3/4 of the modal because we have right padding in all of our containers... i.e. the line length never extends the full width of our containers by design... but this is really a rule that applies to the typography, not so much other elements within a modal. For instance, if you had, say, a data table in the modal, it would take up the full width.

@asudoh
Copy link
Contributor

asudoh commented Jul 17, 2019

Cool thanks @jeanservaas for clarifying!

@asudoh
Copy link
Contributor

asudoh commented Jul 19, 2019

@emyarod Would you agree with swapping width: 75% with padding-right: 25% or a like? Thanks!

@emyarod
Copy link
Member

emyarod commented Jul 19, 2019

@asudoh yeah I think that's fine

@emyarod emyarod self-assigned this Jul 31, 2019
Carbon support automation moved this from Issue: needs triage 💊 to Issue/PR: Closed 🙌 Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants