Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI shell] [react] Last header menu item dropdown is not expanded on click #4718

Closed
2 tasks
pujita9610 opened this issue Nov 19, 2019 · 9 comments · Fixed by #5274
Closed
2 tasks

[UI shell] [react] Last header menu item dropdown is not expanded on click #4718

pujita9610 opened this issue Nov 19, 2019 · 9 comments · Fixed by #5274

Comments

@pujita9610
Copy link

While using Header menu and header menu items the last menu item is not expanded.

Packages and components used:

HeaderNavigation,
HeaderMenu,
HeaderMenuItem

  • carbon-components
  • carbon-components-react

Detailed description

Describe in detail the issue you're having.

Please navigate to this codesandbox url and click the Link 5 menu item then Link 4.

When I click Link4 the sub menu items open and close properly whereas when I click Link 5 the sub menu items open and close immediately. Also just clicking the Link 5 when the Link 4 is clicked the Link 5 sub menu items open.

Is this issue related to a specific component?

Yes. React UI Shell with Header actions and Nav

What did you expect to happen? What happened instead? What would you like to
see changed?

On clicking the menu item it should be active(expanded).

What browser are you working in?

Google

What version of the Carbon Design System are you using?

  • carbon-components -10.4.1
  • carbon-components-react -7.4.1

Please create a reduced test case in CodeSandbox

https://codesandbox.io/s/header-with-actions-and-nav-2pf3p

@Garfield550
Copy link

Same issue.
ezgif com-video-to-gif

@tw15egan
Copy link
Member

Interesting, running it locally I'm not running into any issues when I add in another MenuItem... But I see the issue when I checkout the CodeSandbox. Seems like this may be fixed in the newest release when it's released. I'm seeing a bunch of fixes for UI-Shell that are not out yet: v10.9.2...master

ui-shell

@ndtx
Copy link

ndtx commented Jan 23, 2020

Hit this issue as well. If I empty/remove or put them after HeaderGlobalBar it works, but I need them both as described above.

@tw15egan
Copy link
Member

@ndite like I said, I'm not seeing this locally so I'm hoping this issue will be resolved when we publish our next release

@ndtx
Copy link

ndtx commented Feb 3, 2020

Still happens with the module published 4 days ago (10.9.3, 7.9.3)

https://codesandbox.io/s/header-with-actions-and-nav-qre4k

At this time the issue can be seen here too: https://www.carbondesignsystem.com/components/UI-shell-header/code#header-with-actions-and-nav

@tw15egan
Copy link
Member

tw15egan commented Feb 3, 2020

Still happens with the module published 4 days ago (10.9.3, 7.9.3)

https://codesandbox.io/s/header-with-actions-and-nav-qre4k

Hmm, getting an error when trying to view the latest CodeSandbox..

@xxxle0
Copy link
Contributor

xxxle0 commented Feb 4, 2020

i think the will-change: transform of icon svg effect this behavior.

@tw15egan
Copy link
Member

tw15egan commented Feb 4, 2020

@xxxle0 would simply removing this fix the issue?

@xxxle0
Copy link
Contributor

xxxle0 commented Feb 5, 2020

yep you can test it in codeSandbox by remove will-transfer in 3 svg icon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants