Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data table row sizes not applied when expanded content used #4796

Closed
1 task done
lee-chase opened this issue Nov 28, 2019 · 1 comment · Fixed by #8080
Closed
1 task done

Data table row sizes not applied when expanded content used #4796

lee-chase opened this issue Nov 28, 2019 · 1 comment · Fixed by #8080

Comments

@lee-chase
Copy link
Member

Setting the row size to compact or small using bx--data-table--short or bx--data-table--compact only shrinks the head row.

What package(s) are you using?

  • carbon-components

I would assume all are affected

Detailed description

Describe in detail the issue you're having.
Compact size produces
image

Is this issue related to a specific component?
CvDataTable

What did you expect to happen? What happened instead? What would you like to
see changed?
All rows including expanded content respect the row size.

What browser are you working in?
Chrome

What version of the Carbon Design System are you using?
10.7

What offering/product do you work on? Any pressing ship or release dates we
should be aware of?
None

Steps to reproduce the issue

  1. Go here http://react.carbondesignsystem.com/?path=/story/datatable--with-expansion
    2.Set row height to compact

Additional information

  • Screenshots or code
  • Notes
@jnm2377
Copy link
Contributor

jnm2377 commented Mar 12, 2021

@lee-chase I have a PR up that fixes some issues with different size expandable tables, but I couldn't reproduce any issues in terms of row size. When I added the size variation stories, the chevron was already aligned, and rows were the right height. I just had to update some left padding for the child expandable row.

Design system automation moved this from Backlog to Done Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Design system
  
Done
Development

Successfully merging a pull request may close this issue.

4 participants