Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Notification] Focus outline hard to see on low contrast notifications #5737

Closed
elizabethsjudd opened this issue Mar 27, 2020 · 4 comments · Fixed by #5793
Closed

[Notification] Focus outline hard to see on low contrast notifications #5737

elizabethsjudd opened this issue Mar 27, 2020 · 4 comments · Fixed by #5793

Comments

@elizabethsjudd
Copy link
Contributor

Environment

Operating system

Mac OS X

Browser

All

Automated testing tool and ruleset

AVT 2 and https://www.ibm.com/able/guidelines/ci162/focus_visible.html

Assistive technology used to verify

Keyboard

Detailed description

While visible the focus indicator on low contrast notifications is visible it's very hard to see in the white theme.

What version of the Carbon Design System are you using?

10.10.1

What did you expect to happen?

The focus indicator to be the darker blue color

What happened instead?

The focus indicator is white

What WCAG 2.1 checkpoint does the issue violate?

https://www.ibm.com/able/guidelines/ci162/focus_visible.html

Steps to reproduce the issue

  1. Navigate to https://react.carbondesignsystem.com/?path=/story/notifications--inline
  2. Check the low contrast knob
  3. focus on the close button

Please create a reduced test case in CodeSandbox

It's visible on the Carbon storybook site

Additional information

Screen Shot 2020-03-27 at 4 18 55 PM

@asudoh
Copy link
Contributor

asudoh commented Mar 28, 2020

@elizabethsjudd Thank you for reporting - IIRC #2814 the low contrast version is a "legacy version" that exists primary for (use-case-wise) backward-compatibility. Need to see what the guidance would be in terms of a11y high contrast support and regular/low-contrast notification variants. CC @carbon-design-system/design

@laurenmrice
Copy link
Member

Could we apply our regular focus token when the low contrast is applied? That should solve this issue.

@elizabethsjudd
Copy link
Contributor Author

@laurenmrice Is the low-contrast being depreciated? We have a breaking change coming up in the next week or so and if that's the case, I'd rather remove the low contrast on our end all together. My understanding was that both were going to remain supported in Carbon.

@laurenmrice
Copy link
Member

No low contrast is not being deprecated, we give our users an option to use high contrast or low contrast notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants