Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding "auto" direction to OverflowMenu in DataTable #6551

Closed
GAUNSD opened this issue Jul 24, 2020 · 8 comments
Closed

Adding "auto" direction to OverflowMenu in DataTable #6551

GAUNSD opened this issue Jul 24, 2020 · 8 comments
Labels
adopter: PAL Work-stream that directly helps a Pattern & Asset Library. component: overflow-menu package: @carbon/react @carbon/react proposal: accepted This request has gone through triaging and we are accepting PR's against it. role: dev 🤖 status: help wanted 👐 type: enhancement 💡 version: 11 Issues pertaining to Carbon v11

Comments

@GAUNSD
Copy link

GAUNSD commented Jul 24, 2020

Summary

When using the <OverflowMenu> component, there are times where the direction of the opened menu causes unwanted scrolling in the viewport. Most common use case is for OverflowMenu

I am asking as a developer.

Example

OverflowMenuExample

Justification

The alternative of this feature not being implemented is to use the complex code that detects where the OverflowMenu is, relative to the viewport and change the direction prop passed in.

Desired UX and success metrics

Success will be the menu not causing the parent dom element to cause janky overflows to occur.

"Must have" functionality

an 'auto' direction value that can be passed into the OverflowMenu's direction prop.
auto will tell OverflowMenu to detect which direction to open the menu in.

Specific timeline issues / requests

N/A

NB: The Carbon team will try to work with your timeline, but it's not
guaranteed. The earlier you make a request in advance of a desired delivery
date, the better!

Available extra resources

N/A

@tw15egan tw15egan added proposal: open This request has gone through triaging. We're determining whether we take this on or not. status: help wanted 👐 labels Jul 24, 2020
@laurenmrice laurenmrice added proposal: accepted This request has gone through triaging and we are accepting PR's against it. role: dev 🤖 component: overflow-menu and removed proposal: open This request has gone through triaging. We're determining whether we take this on or not. labels Sep 11, 2020
@laurenmrice
Copy link
Member

Hello! 👋

We are going to move forward with this proposal because we think it would be a great idea to add automation to the overflow menu. We have moved it to our backlog to be worked on.

Thank you!

@tw15egan tw15egan added hacktoberfest See https://hacktoberfest.com/ and removed hacktoberfest See https://hacktoberfest.com/ labels Sep 29, 2020
@tw15egan tw15egan removed the hacktoberfest See https://hacktoberfest.com/ label Jan 28, 2021
@tw15egan
Copy link
Member

Just bumping this because another issue has been raised asking for this functionality: #7689

@David-Yuen
Copy link

Bump to this enhancement request. We are also waiting for this too

@steviesharp123
Copy link

Hello @laurenmrice,
What's the status on this change?

Since the current behavior of the overflow menu causes the whole page to have to be scrolled to view the menu (due to the bottom of the browser the menu can't be displayed properly). We have currently created a work around where the last 3-5 assets on our data table show the menu going upward. This behavior is really odd when there's only a few assets on the table and looks like a defect.

It would be so helpful to have this functionality added to the carbon component that @GAUNSD mentioned above, so we could remove this work around.

Screen Shot 2021-11-29 at 11 14 12 AM
le

@David-Yuen
Copy link

Bump^, still waiting for this

@tw15egan
Copy link
Member

As far as I am aware, there are no current workstreams attached to this issue. With the release of V11, we may be able to replace the internal FloatingMenu component with the Popover component, as Popover has the autoAlign functionality. Any PR's exploring this functionality would be welcome.

@sstrubberg sstrubberg added adopter: PAL Work-stream that directly helps a Pattern & Asset Library. adopter: DSAG version: 11 Issues pertaining to Carbon v11 package: @carbon/react @carbon/react and removed adopter: DSAG labels Dec 1, 2022
@sstrubberg sstrubberg changed the title [carbon-components-react] Adding "auto" direction to OverflowMenu Adding "auto" direction to OverflowMenu Aug 22, 2023
@sstrubberg
Copy link
Member

ref #14139

@tay1orjones tay1orjones changed the title Adding "auto" direction to OverflowMenu Adding "auto" direction to OverflowMenu in DataTable Jun 26, 2024
@riddhybansal
Copy link
Contributor

Hi there everyone this has been fixed by #14139
Here is the stackblitz example of the same. The overflow menu will align itself wherever it will get space without creating any extra scrollbars in datatable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adopter: PAL Work-stream that directly helps a Pattern & Asset Library. component: overflow-menu package: @carbon/react @carbon/react proposal: accepted This request has gone through triaging and we are accepting PR's against it. role: dev 🤖 status: help wanted 👐 type: enhancement 💡 version: 11 Issues pertaining to Carbon v11
Projects
Archived in project
Development

No branches or pull requests

7 participants