Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab: renderAnchor/renderButton no longer runs cleanly #7416

Closed
2 tasks done
richardpilot opened this issue Dec 8, 2020 · 0 comments · Fixed by #7418
Closed
2 tasks done

Tab: renderAnchor/renderButton no longer runs cleanly #7416

richardpilot opened this issue Dec 8, 2020 · 0 comments · Fixed by #7418

Comments

@richardpilot
Copy link

richardpilot commented Dec 8, 2020

What package(s) are you using?

  • carbon-components
  • carbon-components-react

Detailed description

The following PR, #6989, deprecated renderAnchor, suggesting an alternative renderButton to achieve the same result. However, the current state of the Tab component means that it is no longer possible for it to run cleanly with either prop without a warning.

Using renderAnchor produces the deprecated warning.
https://codesandbox.io/s/festive-jones-i6x5k?file=/src/index.js

Using renderButton produces an unrecognised prop warning and also doesn't work
https://codesandbox.io/s/pensive-chatterjee-9mxnm?file=/src/index.js

What did you expect to happen? What happened instead? What would you like to
see changed?

If the intention is to rename renderAnchor to renderButton then the new prop should be available to use in PropTypes.

@emyarod emyarod self-assigned this Dec 8, 2020
@richardpilot richardpilot changed the title Tab renderAnchor/renderButton no longer runs cleanly Tab: renderAnchor/renderButton no longer runs cleanly Dec 8, 2020
@kodiakhq kodiakhq bot closed this as completed in #7418 Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants