Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[naming convention] tag and toggle sizes #8045

Closed
laurenmrice opened this issue Mar 9, 2021 · 0 comments · Fixed by #8049
Closed

[naming convention] tag and toggle sizes #8045

laurenmrice opened this issue Mar 9, 2021 · 0 comments · Fixed by #8049
Assignees
@emyarod
Labels
component: tags component: toggle role: dev 🤖 type: docs 📖

Comments

@laurenmrice
Copy link
Member

  • Tag and Toggle cmponents need to have the same naming convention for their two different sizes in react.

  • This is a little bit different from the t-shirt sizes for most form components mentioned here 2021 Release Proposals #7538 (comment), but these can follow a similiar structure when it comes to adding /default.

Tag:

  • Big/default: 24px
  • Small: 18px

Toggle:

  • Big/default: 24px
  • Small: 16px
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emyarod emyarod

Labels
component: tags component: toggle role: dev 🤖 type: docs 📖
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: update default size knob description for Tag and Toggle emyarod/carbon
2 participants
@emyarod @laurenmrice