Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Size Prop across components #8370

Closed
24 tasks done
tw15egan opened this issue Apr 12, 2021 · 0 comments
Closed
24 tasks done

Update Size Prop across components #8370

tw15egan opened this issue Apr 12, 2021 · 0 comments
Assignees
@tw15egan @jnm2377
Labels
epic Special label used by ZenHub for epic functionality package: react carbon-components-react role: dev 🤖 type: enhancement 💡

Comments

@tw15egan
Copy link
Member

tw15egan commented Apr 12, 2021 •
edited
Loading

We want to align all size props so that a user knows exactly what size to expect based on the value they provide.

Based on the following table:

Name Size
xs 24
sm 32
md 40
lg 48
xl 64
2xl 80

Components to be updated

  • Accordion
  • Button
  • Listbox
    • Combobox
    • Dropdown
    • Multiselect
    • Filterable Multiselect
  • Content Switcher
  • DatePicker
  • FileUploader
    • FileUploaderButton
    • FileUploaderDropContainer
    • FileUploaderItem
  • Link
  • Modal
    • ComposedModal
  • Number Input
  • Overflow Menu
  • Search
  • Select
  • Tag
  • Text Input
  • Time Picker
  • Toggle

Form elements have been worked on in #8160

Outstanding work is tracked in #8369
@tw15egan tw15egan added epic Special label used by ZenHub for epic functionality package: react carbon-components-react role: dev 🤖 type: enhancement 💡 labels Apr 12, 2021
@tw15egan tw15egan mentioned this issue Apr 12, 2021
Merged
24 tasks
This was referenced Apr 14, 2021
Closed
Closed
@tw15egan tw15egan mentioned this issue Apr 16, 2021
Closed
@aagonzales aagonzales mentioned this issue Apr 29, 2021
Closed
@joshblack joshblack mentioned this issue May 3, 2021
Closed
@tw15egan tw15egan mentioned this issue May 3, 2021
Merged
@aagonzales aagonzales mentioned this issue Jun 3, 2021
Closed
4 tasks
@emyarod emyarod mentioned this issue Dec 6, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tw15egan tw15egan

@jnm2377 jnm2377

Labels
epic Special label used by ZenHub for epic functionality package: react carbon-components-react role: dev 🤖 type: enhancement 💡
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tw15egan @jnm2377