fix(scss): import + other minor fixes #1410

muditjuneja · 2024-02-03T02:55:54Z

This PR aims at fixing a few things that are causing build failures which include -

Mdx updated format
Fix a few imports as per the upgrades

This PR should be merged to the next branch.

vercel · 2024-02-03T02:55:59Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
gatsby-theme-carbon	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 6, 2024 3:26pm

muditjuneja · 2024-02-03T03:06:18Z

@eng618 Can you review this PR?

eng618

Looks mostly good, and while it compiles locally, we are picking up the wrong theme in the pages. I feel like this is because the tokens are not being picked up or imported correctly.

vs what it should be:

packages/gatsby-theme-carbon/src/components/Code/Code.js

packages/gatsby-theme-carbon/src/components/LeftNav/LeftNavItem.js

packages/gatsby-theme-carbon/src/components/Code/Code.js

muditjuneja · 2024-02-03T19:37:09Z

@eng618 useMetadata was not being called in DefaultLayout and it was not able to supply the theme variables. Fixed it by calling the method.
Another thing that I am noticing is that the Code component is not working as expected and we would need to look more into that. Other than this, build looks good.

muditjuneja · 2024-02-03T19:41:05Z

packages/gatsby-theme-carbon/src/components/Code/Code.js

-    const [lastLine] = lines.splice(-1);
-    if (lastLine[0].empty) {
-      return lines;
+    if (lines && lines.length) {


These checks are almost random that I applied to make the build work as this component could not find lines in a few pages. It would make sense to look into this as a separate PR.

muditjuneja · 2024-02-03T20:18:13Z

Also,
Text defined like below -

The <ResourceCard> component should be wrapped with a <Column> inside of
<Row className="resource-card-group"> or
<Row className="resource-card-group-3-across">. This allows the correct border
placement between a group of cards spanning 2 or 3 across.

is being rendered differently in the new version and the older live build. See the diff below

packages/gatsby-theme-carbon/src/components/Code/Code.js

eng618

Just a couple minor things, then we can get this merged in.

packages/example/src/pages/components/markdown.mdx

packages/gatsby-theme-carbon/src/components/Code/Code.js

This reverts commit ffa7fbc.

@commitlint

* feat(deps): update node to 18 (#1278) * build(deps): update node to 18 Also update all other dependencies - update all minor dependencies #1277 * chore: bump everything to node 18 * chore: update gatsby-plugin-sass * chore: update readme with status badge * docs: typo correction * docs: update structure * ci: update .github/workflows/manual-release.yml Co-authored-by: Scott Strubberg <sstrubberg@protonmail.com> * ci: update commitlint version and docs Co-authored-by: Scott Strubberg <sstrubberg@protonmail.com> * chore: release 4.0.0-next.0 * chore: release 4.0.0-next.1 * build: bump deps * chore: release 4.0.0-next.2 * build: update node version * build: update deps * build: gatsby v5 * fix: run gatsby codemods npx gatsby-codemods@latest sort-and-aggr-graphql . * build: define trailingSlash * build: bump dependencies * refactor: apply formatting * refactor(eslint): comment out unused imorts * refactor: apply formatting * start update mdx * build(deps): bump minor and below versions * build: update lerna * formatting... * feat: update release-it * feat: update @commitlint * ci: add github actions updater * build: move some deps down to devDependencies * build: update all things * formatting... * build: dep updates * fix: remove extraLayouts This is not longer supported as you can define your own layouts as components, following this guide: https://www.gatsbyjs.com/docs/how-to/routing/layout-components/ * build: bump dependencies * chore: update sass resources loader to compatible version * build: bump deps * docs: start migration doc * chore: rebuild yarn lock * build(deps): update minor and below * build(deps): update minor and below * feat(layouts): start converting to use layouts * build: rebuild lock file * build: cleanup unknown property * build(deps): update minor and below * build(deps): bump minor and below * fix(path): update layout path * linter fixes * chore: update changelog settings * build(deps): bump minor and below And other minor adjustments. * chore: add recommended plugins * fix(scss): import + other minor fixes (#1410) * Fixing scss import + other minor fixes * Fixing useMetadata in Default Layout * lint fixing * bring back defaultProps * Fixing inline code blocks * Minor info comment * More suggested changes * remove white space * testing vercel again * Fixing yarn * fixing yarn * chore(deps): bump minor and below * fix(format): run prettier * fix(lint): update wesbos * fix: linting,imports in code (#1414) * build(deps): update release-it workspaces * docs: update code block * chore: release 4.0.0-next.4 [skip ci], * chore: update lock file * Fix : mdx tables + port to esm v2 (#1418) * fix: mdx tables + port gatsby core to ESM * chore: bring back js files via using type * updating the order of remarkGfm Co-authored-by: Eric Garcia <engarcia618@gmail.com> * fix: updatng remarkGfm order Co-authored-by: Eric Garcia <engarcia618@gmail.com> * chore: add a space * fix: mdx-tables --------- Co-authored-by: Eric Garcia <engarcia618@gmail.com> * fix(yarn): revert lock file changes * fix: v5 issues (#1431) * fix: image spacing * fix: blockquote styles * fix: prop table display * fix: image gallery display * fix: markdown link with title * docs: update migration guide * build: maintian dependencies * build: rebuild lock file * Fix: code blocks in mdx + issues/868 (#1422) * fix: heading spacing * build: bump yarn * fix: nested list styling for v5 (#1438) Co-authored-by: Eric Garcia <eng618@garciaericn.com> * style: apply formatting * chore: release 4.0.0-next.5.0 [skip ci], * build(deps): bump minor * fix: copy button color token (#1441) * fix: copy button color token * chore: remove extra file changes * fix: regression in code blocks - default prop (#1442) * docs: code blocks docs page (#1443) * docs: code snippet docs page * fix: hidecode prop check * fix formatting * fix: release * chore: release 4.0.0-next.7 [skip ci], * refactor: change hideCode prop to showAll prop (#1445) * refactor: change hideCode prop to showAll prop * fix: yan lock file * fix: feedback form button style * fix: warnings (#1450) * fix: warnings * fix: swap back to mjs file * fix: caption styles (#1451) * fix formatting * chore: release 4.0.0-next.8 [skip ci], * feat(next): add gatsby-plugin-local-search (#1464) * feat(next): add gatsby-plugin-local-search remove gatsby-plugin-lunr * feat(next): add gatsby-plugin-local-search remove gatsby-plugin-lunr * feat: add path * chore: remove old code * chore: clean up code * chore: cleanup * feat: fix tabs * feat: create search config file * chore: release 4.0.0-next.9 [skip ci], * feat: add max results to search (#1466) * chore: release 4.0.0-next.10 [skip ci], * build(deps): bump minor and below * chore: release 4.0.0-next.11 [skip ci], * build(yarn): update lock file * docs: update migration guide * fix(deps): add missing preset * docs: update migration guide * chore: cleanup * fix: update homepage link to v4 migration --------- Co-authored-by: Scott Strubberg <sstrubberg@protonmail.com> Co-authored-by: Mudit Juneja <muditjuneja@outlook.com> Co-authored-by: Alison Joseph <alisonejoseph@Gmail.com> Co-authored-by: Alison Joseph <alison.joseph@us.ibm.com>

vercel bot deployed to Preview February 3, 2024 02:58 View deployment

eng618 self-assigned this Feb 3, 2024

Fixing scss import + other minor fixes

a3a4070

eng618 force-pushed the no-issue/fix/scss-upgrades-and-minor-mdx-fix branch from aa86568 to a3a4070 Compare February 3, 2024 04:17

eng618 changed the title ~~Fixing scss import + other minor fixes~~ fix(scss): import + other minor fixes Feb 3, 2024

vercel bot deployed to Preview February 3, 2024 04:22 View deployment

eng618 requested changes Feb 3, 2024

View reviewed changes

packages/gatsby-theme-carbon/src/components/Code/Code.js Outdated Show resolved Hide resolved

packages/gatsby-theme-carbon/src/components/LeftNav/LeftNavItem.js Outdated Show resolved Hide resolved

packages/gatsby-theme-carbon/src/components/Code/Code.js Outdated Show resolved Hide resolved

muditjuneja added 3 commits February 4, 2024 00:53

Fixing useMetadata in Default Layout

92d5544

lint fixing

0cbabaa

bring back defaultProps

8c27473

vercel bot deployed to Preview February 3, 2024 19:36 View deployment

muditjuneja commented Feb 3, 2024

View reviewed changes

muditjuneja requested a review from eng618 February 3, 2024 19:42

muditjuneja added 2 commits February 4, 2024 03:54

Fixing inline code blocks

4aa3242

Minor info comment

6cf8208

vercel bot deployed to Preview February 3, 2024 22:30 View deployment

muditjuneja commented Feb 3, 2024

View reviewed changes

packages/gatsby-theme-carbon/src/components/Code/Code.js Show resolved Hide resolved

eng618 requested changes Feb 5, 2024

View reviewed changes

packages/example/src/pages/components/markdown.mdx Outdated Show resolved Hide resolved

packages/gatsby-theme-carbon/src/components/Code/Code.js Show resolved Hide resolved

muditjuneja and others added 3 commits February 6, 2024 00:27

More suggested changes

e55f748

Merge branch 'next' into no-issue/fix/scss-upgrades-and-minor-mdx-fix

23cc672

remove white space

d20059e

muditjuneja requested a review from eng618 February 5, 2024 19:06

vercel bot had a problem deploying to Preview February 5, 2024 20:02 Failure

testing vercel again

8999d09

vercel bot had a problem deploying to Preview February 6, 2024 13:19 Failure

Fixing yarn

6db5b0b

vercel bot had a problem deploying to Preview February 6, 2024 14:56 Failure

fixing yarn

fb32aa8

vercel bot deployed to Preview February 6, 2024 15:26 View deployment

eng618 approved these changes Feb 6, 2024

View reviewed changes

eng618 merged commit ffa7fbc into carbon-design-system:next Feb 6, 2024
2 of 3 checks passed

alisonjoseph added a commit that referenced this pull request Feb 6, 2024

Revert "fix(scss): import + other minor fixes (#1410)"

14f6c0b

This reverts commit ffa7fbc.

alisonjoseph mentioned this pull request Feb 6, 2024

Revert "fix(scss): import + other minor fixes" #1412

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(scss): import + other minor fixes #1410

fix(scss): import + other minor fixes #1410

muditjuneja commented Feb 3, 2024 •

edited

vercel bot commented Feb 3, 2024 •

edited

muditjuneja commented Feb 3, 2024

eng618 left a comment

muditjuneja commented Feb 3, 2024

muditjuneja Feb 3, 2024

muditjuneja commented Feb 3, 2024 •

edited

eng618 left a comment

fix(scss): import + other minor fixes #1410

fix(scss): import + other minor fixes #1410

Conversation

muditjuneja commented Feb 3, 2024 • edited

vercel bot commented Feb 3, 2024 • edited

muditjuneja commented Feb 3, 2024

eng618 left a comment

Choose a reason for hiding this comment

muditjuneja commented Feb 3, 2024

muditjuneja Feb 3, 2024

Choose a reason for hiding this comment

muditjuneja commented Feb 3, 2024 • edited

eng618 left a comment

Choose a reason for hiding this comment

muditjuneja commented Feb 3, 2024 •

edited

vercel bot commented Feb 3, 2024 •

edited

muditjuneja commented Feb 3, 2024 •

edited