fix(dataspreadsheet): Change condition check (fix regression) #5527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AustinGitHub
requested review from
emyarod and
annawen1
and removed request for
a team
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
AustinGitHub
changed the title
AustinGitHub
commented
Jun 18, 2024
packages/ibm-products/src/components/DataSpreadsheet/DataSpreadsheet.tsx
Show resolved
Hide resolved
matthewgallo
approved these changes
Jun 19, 2024
Merged
via the queue into
carbon-design-system:main
with commit Jun 19, 2024
795cd23
22 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5526
What did you change?
Fix condition check, see issue videos on why this condition check changed
How did you test and verify your work?
Story book, original use case still works. Won't know absolute fix until next version release since issue seems to be coming through due to how the importing of the component is happening.