Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decide on node cluster options and behavior #9

Closed
gregbanks opened this issue Feb 22, 2016 · 5 comments
Closed

decide on node cluster options and behavior #9

gregbanks opened this issue Feb 22, 2016 · 5 comments
Assignees

Comments

@gregbanks
Copy link
Contributor

node cluster support is enabled when passing the --cluster flag. the number of worker processes started defaults to the number of CPUs present and is configurable with the --num-cluster-workers option.

what other options do we need? do we want the master to automatically restart workers? do we want to have a command line flag to control this?

@willshulman
Copy link
Contributor

If the master can auto-restart workers I guess that is cool. What is the default for Node, and what does it look like when one worker crashes?

If we do do it I think we should control with flag.

@willshulman
Copy link
Contributor

For now lets just logError when child dies or fail hard (the whole cluster). Make this configurable via 'exitOnUnexpectedWorkerExit'

Then make P2 and later let's do more and have configuration around restarting and how often and which errors can cause restarts and which cannot.

@gregbanks
Copy link
Contributor Author

sounds good, on this tomorrow

@gregbanks
Copy link
Contributor Author

let me know how this looks

c8a015b

@willshulman
Copy link
Contributor

Wow. Seems very non-trivial to implement exitOnUnexpectedWorkerExit although it also looks like you found some ways in which code I added since the first cluster impl did not properly account for cluster-ness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants