Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation website #1526

Closed
wants to merge 24 commits into from
Closed

Documentation website #1526

wants to merge 24 commits into from

Conversation

emlai
Copy link

@emlai emlai commented Jul 21, 2022

Closes #1492. Adds a website that is auto-generated from the markdown files in the repo, using Docusaurus. This will make it easier to browse the docs, by adding a navigation sidebar as well as a table-of-contents sidebar, mobile support, and other things. The site can be autodeployed to https://carbon-language.github.io/ (or to a custom domain using a CNAME file), and is currently configured accordingly (deployment instructions in website/README.md).

  • The front page is generated from the repository root readme.
  • The top navigation items Design, Project, Guides, and Spec corresponds to the respective directories under docs/.
  • Footer has links to GitHub repo, Discord, and Code of Conduct.

Preview: https://emlai.github.io/

To do:

  • Render mermaid diagrams.
  • Before or after merging, for someone with admin access to the organization: Create carbon-language.github.io repo, enable GitHub Pages for it, and configure deploy keys (instructions). You can ping me (emlai#9471) on Discord if you need help.

Follow-up improvements (non-blocking tasks that are not necessary for merging this PR):

  • Mention in docs that they get auto-deployed to the website when a change is pushed to trunk.
  • Add site-wide search such as Algolia which will scrape the site and host the search index in their own database. Requires that the site is deployed first before setting up.
  • Fix broken links and enable Docusaurus link validation (src), blocked by Docusaurus issue: Relative markdown links broken facebook/docusaurus#7829
  • Fix description meta tags, currently <!--: <meta data-rh="true" name="description" content="<!--">

How to test

Go to https://emlai.github.io/ and check that links, navigation, etc. works, and everything looks ok.

@google-cla
Copy link

google-cla bot commented Jul 21, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@nomandhoni-cs
Copy link

@emlai,
How can I contribute to the Documentation Website?

What if, we use the CppNorth video as iframe in the website instead of using the video link?

@emlai
Copy link
Author

emlai commented Jul 24, 2022

@nomandhoni-cs Hi! You can contribute by making a PR to this branch in my fork. We can sync on the Carbon Discord, I'm emlai#9471 there.

As for converting youtube links into embeds in the markdown, it should be possible using remark plugins such as https://github.com/agentofuser/remark-oembed.

@emlai emlai changed the title [WIP] Documentation website Documentation website Jul 24, 2022
@emlai emlai marked this pull request as ready for review July 24, 2022 19:58
@jonmeow
Copy link
Contributor

jonmeow commented Jul 26, 2022

Depends on #1492

@zygoloid
Copy link
Contributor

This is looking really promising!

It looks like mermaid diagrams aren't being rendered by this documentation generation pipeline: for example, the precedence diagram at https://emlai.github.io/docs/design/expressions/ is rendered as text. It looks like there's an external implementation of mermaid rendering for docusaurus available already, and native support coming soon.

@github-actions
Copy link

github-actions bot commented Dec 3, 2022

We triage inactive PRs and issues in order to make it easier to find active work. If this PR should remain active, please comment or remove the inactive label.
This PR is labeled inactive because the last activity was over 90 days ago. This PR will be closed and archived after 14 additional days without activity.

@github-actions github-actions bot added the inactive Issues and PRs which have been inactive for at least 90 days. label Dec 3, 2022
@github-actions
Copy link

We triage inactive PRs and issues in order to make it easier to find active work. If this PR should remain active or becomes active again, please reopen it.
This PR was closed and archived because there has been no new activity in the 14 days since the inactive label was added.

@github-actions github-actions bot closed this Dec 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inactive Issues and PRs which have been inactive for at least 90 days.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need a website for documentation
4 participants