Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Carbon: Lexical conventions #17

Closed
wants to merge 11 commits into from
Closed

Carbon: Lexical conventions #17

wants to merge 11 commits into from

Commits on Jun 15, 2020

  1. P0016 Lexical conventions, first draft.

    @zygoloid
    zygoloid committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    735ac21 View commit details
    Browse the repository at this point in the history

  2. Rephrase introduction of list of ASCII whitespace characters. 

    Co-authored-by: Dmitri Gribenko <gribozavr@gmail.com>
    @zygoloid @gribozavr
    zygoloid and gribozavr committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    511a972 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Dmitri Gribenko <gribozavr@gmail.com>
Co-authored-by: josh11b <josh11b@users.noreply.github.com>
    @zygoloid @gribozavr @josh11b
    3 people committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    22ed0b8 View commit details
    Browse the repository at this point in the history

  4. Recognize 0 as an integer literal.

    @zygoloid
    zygoloid committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    cc207d1 View commit details
    Browse the repository at this point in the history

  5. Updates based on review feedback.

    @zygoloid
    zygoloid committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    bce8eb4 View commit details
    Browse the repository at this point in the history

  6. New rules for block comments based on review feedback.

    @zygoloid
    zygoloid committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    7f1c242 View commit details
    Browse the repository at this point in the history

  7. Add open question from review feedback.

    @zygoloid
    zygoloid committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    29c5e4a View commit details
    Browse the repository at this point in the history

  8. Apply suggestions from code review 

    Co-authored-by: austern <austern@google.com>
Co-authored-by: Jon Meow <46229924+jonmeow@users.noreply.github.com>
    @zygoloid @austern @jonmeow
    3 people committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    b94320e View commit details
    Browse the repository at this point in the history

  9. Updates from review feedback.

    @zygoloid
    zygoloid committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    cd7335f View commit details
    Browse the repository at this point in the history

  10. Add details on directionality based on discussion in the context of 

    issue#19.
    @zygoloid
    zygoloid committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    09117de View commit details
    Browse the repository at this point in the history

  11. Expand directionality discussion, relocate to be adjacent to encoding 

    discussion, and convert the suggestion that we enforce directionality to
an open question.
    @zygoloid
    zygoloid committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    fffd2fb View commit details
    Browse the repository at this point in the history