Consistent class and interface syntax
#2760
Merged
+841
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josh11b
added
proposal
github-actions
bot
added
the
proposal rfc
|
Please pay particular attention to the alternatives, I'm not sure that I have captured everything important we considered in #995 . |
|
I have a draft PR #2866 for updating the syntax in the design docs, if you would like to see how this looks in a number of examples. |
zygoloid
reviewed
Jun 2, 2023
Co-authored-by: Richard Smith <richard@metafoo.co.uk>
chandlerc
reviewed
Jun 6, 2023
zygoloid
approved these changes
Jun 15, 2023
There was a problem hiding this comment.
Approving on behalf of leads. This reflects decisions from prior leads issues, with a scope reduction for require that @chandlerc and I are both happy with and that seems to generally improve consensus. Thanks!
josh11b
added a commit
to josh11b/carbon-lang
that referenced
this pull request
Jun 15, 2023
josh11b
added a commit
that referenced
this pull request
Jun 15, 2023
Implement syntax changes from #2760 in Explorer
josh11b
added a commit
that referenced
this pull request
Jun 16, 2023
This includes:
- Syntax changes from this chart:
| Before | After |
| ------------------------------- | --------------------------------------- |
| `class D extends B { ... }` | `class D { extend base: B; ... }` |
| `external impl C as Sub;` | `impl C as Sub;` |
| `class C { impl as Sortable; }` | `class C { extend impl as Sortable; }` |
| `adapter A for C { ... }` | `class A { adapt C; ... }` |
| `adapter A extends C { ... }` | `class A { extend adapt C; ... }` |
| `interface I { impl as J; }` | `interface I { require Self impls J; }` |
| `interface I { extends J; }` | `interface I { extend J; }` |
- Dropping the syntax for conditionally implemented internal interfaces.
This does not include:
- terminology changes from #2760 ("internal" and "external")
- changes to code, such as explorer, toolchain, language grammars, or other tooling
Merged
josh11b
added a commit
to josh11b/carbon-lang
that referenced
this pull request
Jun 17, 2023
josh11b
added a commit
that referenced
this pull request
Jun 19, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 2, 2023
This reflects changes from a number of approved proposals: - #920 : concrete statements about orphan and overlap in Carbon - #2138 : "generic" -> "checked generic", "template" -> "template generic" - #2188 : binding patterns are forbidden in type position - #2360 : "type", "facet type", "facet". Note: I am not using the term "generic type" from #2360 since that meaning conflicts with the generally accepted meaning of "generic type" of a type with a compile-time parameter. - #2760 / #2770 : internal/external impl -> extending impl - #2964 : "symbolic constant" and "template constant" --------- Co-authored-by: Geoff Romer <gromer@google.com> Co-authored-by: Richard Smith <richard@metafoo.co.uk>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 15, 2023
This reflects changes from a number of approved proposals: - #2138 : "generic" -> "checked generic", "template" -> "template generic" - #2360 : "type", "facet type", "facet". Note: I am not using the term "generic type" from #2360 since that meaning conflicts with the generally accepted meaning of "generic type" of a type with a compile-time parameter. - #2760 / #2770 : internal/external impl -> extending impl - #2964 : "symbolic constant" and "template constant" --------- Co-authored-by: Richard Smith <richard@metafoo.co.uk>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 23, 2023
Includes proposals: - #990 - #2188 - #2138 - #2200 - #2360 - #2760 - #2964 - #3162 Also tries to use more precise language when talking about: - implementations, to avoid confusing `impl` declaration and definitions with the `impls` operator used in `where` clauses, an issue brought up in #2495 and #2483; - "binding patterns", like `x: i32`, and "bindings" like `x`. --------- Co-authored-by: Chandler Carruth <chandlerc@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update syntax of
classandinterfacedefinitions to be more consistent. Constructs that add names to the class or interface from another definition are always prefixed by theextendkeyword.Implements the decisions in: