Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse parameters in name qualifiers. #3988

Merged
merged 7 commits into from
May 29, 2024
Merged

Parse parameters in name qualifiers. #3988

merged 7 commits into from
May 29, 2024

Commits on May 24, 2024

  1. Parse parameters in name qualifiers. 

    Parse the name of a declaration as a sequence of name qualifiers --
which have a name, possibly parameters, and a trailing period --
followed by a name and possibly parameters.

Cases like namespaces that can't actually have parameters are now
diagnosed in check instead of in parse.
    @zygoloid
    zygoloid committed May 24, 2024
    Configuration menu
    Copy the full SHA
    7848bbc View commit details
    Browse the repository at this point in the history

  2. Underline parameters when rejecting them.

    @zygoloid
    zygoloid committed May 24, 2024
    Configuration menu
    Copy the full SHA
    b1ae4eb View commit details
    Browse the repository at this point in the history

  3. Cleanups.

    @zygoloid
    zygoloid committed May 24, 2024
    Configuration menu
    Copy the full SHA
    5058d05 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2024

  1. Fix unit test.

    @zygoloid
    zygoloid committed May 25, 2024
    Configuration menu
    Copy the full SHA
    30ec4bc View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. Fix typo. 

    Co-authored-by: Jon Ross-Perkins <jperkins@google.com>
    @zygoloid @jonmeow
    zygoloid and jonmeow committed May 28, 2024
    Configuration menu
    Copy the full SHA
    b30b41b View commit details
    Browse the repository at this point in the history

  2. Fix numbering. 

    Co-authored-by: Jon Ross-Perkins <jperkins@google.com>
    @zygoloid @jonmeow
    zygoloid and jonmeow committed May 28, 2024
    Configuration menu
    Copy the full SHA
    4abfc85 View commit details
    Browse the repository at this point in the history

  3. Review comment.

    @zygoloid
    zygoloid committed May 28, 2024
    Configuration menu
    Copy the full SHA
    c99f62a View commit details
    Browse the repository at this point in the history