Fix quirks in debug printing #4088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonmeow
force-pushed
the
fix-import-ir-inst
branch
from
6bf3ecd
to
7486b24
Compare
zygoloid
approved these changes
Jun 27, 2024
| using ValueType = ImportIRInst; | ||
|
|
||
| // An explicitly invalid ID. | ||
| static const ImportIRInstId Invalid; | ||
|
|
||
| using IdBase::IdBase; | ||
|
|
||
| auto Print(llvm::raw_ostream& out) const -> void { | ||
| out << "import_ir_inst"; |
There was a problem hiding this comment.
We seem to have no test coverage for this; can you add some?
There was a problem hiding this comment.
Done. Also started printing the import_ir_inst list, and adjusted formatting for that and ImportIR.
jonmeow
force-pushed
the
fix-import-ir-inst
branch
2 times, most recently
from
da4e27d
to
23cb96e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, I noticed that ImportIRInst didn't print properly while trying to debug an issue, and that's where this started. Then I was sort of trying to figure out why we have "type_blocks" but "typeBlock", so trying to make that more consistent. "importIRInst0" felt more odd than "import_ir_inst0" which is why I'm suggesting down this particular route, but let me know if you'd prefer the reverse (but then do we also do "typeBlocks", etc, removing the consistency with the member name?)
Also starting to print more detail on import_irs, and added import_ir_insts (adjusting formatting for that too).